From 18cbe2979e8fb3de38b6591de3ff694dbeaa5a8e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=81ngel=20Montero=20Lamas?= <angel.montero1@gmail.com>
Date: Tue, 2 Jan 2024 17:22:44 +0100
Subject: [PATCH] fixed code as Azgaar suggested

+ Corrected provincesHeader distance in em.
+ const stateId = pack.provinces[p].state;
- Deleted cell count.
---
 index.html                     | 2 +-
 modules/ui/provinces-editor.js | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/index.html b/index.html
index e75b7d39..230f6995 100644
--- a/index.html
+++ b/index.html
@@ -4450,7 +4450,7 @@
       </div>
 
       <div id="provincesEditor" class="dialog stable" style="display: none">
-        <div id="provincesHeader" class="header" style="grid-template-columns: 11em 8em 8em 6em 6em 7em 8em">
+        <div id="provincesHeader" class="header" style="grid-template-columns: 11em 8em 8em 6em 6em 6em 8em">
           <div data-tip="Click to sort by province name" class="sortable alphabetically" data-sortby="name">
             Province&nbsp;
           </div>
diff --git a/modules/ui/provinces-editor.js b/modules/ui/provinces-editor.js
index 6a947dab..08e5fbea 100644
--- a/modules/ui/provinces-editor.js
+++ b/modules/ui/provinces-editor.js
@@ -44,14 +44,14 @@ function editProvinces() {
       cl = el.classList,
       line = el.parentNode,
       p = +line.dataset.id;
-    const stateId = +document.getElementById("provincesFilterState").value;
+    const stateId = pack.provinces[p].state;
 
     if (el.tagName === "FILL-BOX") changeFill(el);
     else if (cl.contains("name")) editProvinceName(p);
     else if (cl.contains("coaIcon")) editEmblem("province", "provinceCOA" + p, pack.provinces[p]);
     else if (cl.contains("icon-star-empty")) capitalZoomIn(p);
     else if (cl.contains("icon-flag-empty")) triggerIndependencePromps(p);
-    else if (cl.contains("icon-dot-circled")) overviewBurgs({stateId}); // {stateId}, filtered view for that state
+    else if (cl.contains("icon-dot-circled")) overviewBurgs({stateId});
     else if (cl.contains("culturePopulation")) changePopulation(p);
     else if (cl.contains("icon-pin")) toggleFog(p, cl);
     else if (cl.contains("icon-trash-empty")) removeProvince(p);
@@ -187,7 +187,6 @@ function editProvinces() {
 
     // update footer
     provincesFooterNumber.innerHTML = filtered.length;
-    byId("provincesFooterCells").innerHTML = pack.cells.h.filter(h => h >= 20).length;
     byId("provincesFooterBurgs").innerHTML = totalBurgs;
     provincesFooterArea.innerHTML = filtered.length ? si(totalArea / filtered.length) + unit : 0 + unit;
     provincesFooterPopulation.innerHTML = filtered.length ? si(totalPopulation / filtered.length) : 0;