backups/Fantasy-Map-Generator
1
0
Fork 0
mirror of https://github.com/Azgaar/Fantasy-Map-Generator.git synced 2026-02-05 01:51:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: update port type from string to number and add tests for inland burgs (#1292)
Some checks are pending
Deploy static content to Pages / deploy (push) Waiting to run
Details
Code quality / quality (push) Waiting to run
Details

Browse source
This commit is contained in:
Marc Emmanuel 2026-01-30 13:42:33 +01:00 • committed by GitHub
parent e938bc7802
commit 363c82ee30
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 115 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/modules/burgs-generator.ts
View file

@ -15,7 +15,7 @@ export interface Burg {
feature?: number;
capital?: number;
lock?: boolean;
port?: string;
port?: number;
removed?: boolean;
population?: number;
type?: string;
@ -81,7 +81,7 @@ class BurgModule {
Object.entries(featurePortCandidates).forEach(([featureId, burgs]) => {
if (burgs.length < 2) return; // only one port on water body - skip
burgs.forEach((burg) => {
burg.port = featureId;
burg.port = Number(featureId);
const haven = cells.haven[burg.cell];
const [x, y] = getCloseToEdgePoint(burg.cell, haven);
burg.x = x;
@ -237,7 +237,7 @@ class BurgModule {
}
}
getType(cellId: number, port: string) {
getType(cellId: number, port?: number) {
const { cells, features } = pack;
if (port) return "Naval";
@ -272,7 +272,7 @@ class BurgModule {
}
private defineEmblem(burg: Burg) {
burg.type = this.getType(burg.cell, burg.port as string);
burg.type = this.getType(burg.cell, burg.port);
const state = pack.states[burg.state as number];
const stateCOA = state.coa;
@ -485,7 +485,7 @@ class BurgModule {
const population = rn(burgPopulation! * populationRate * urbanization);
const river = cells.r[cell] ? 1 : 0;
const coast = Number(parseInt(burg.port as string, 10) > 0);
const coast = Number((burg.port || 0) > 0);
const sea = (() => {
if (!coast || !cells.haven[cell]) return null;
@ -672,7 +672,7 @@ class BurgModule {
name,
feature,
capital: 0,
port: "0",
port: 0,
};
this.definePopulation(burg);
this.defineEmblem(burg);