From 40d08ccc84abaa46d2d1a584feca9bc9c4bcd41a Mon Sep 17 00:00:00 2001
From: Azgaar <azgaar.fmg@yandex.com>
Date: Wed, 28 Aug 2024 16:52:07 +0200
Subject: [PATCH] feat: zones editor - update editor

---
 index.html                    |   6 +-
 modules/ui/burg-editor.js     |  62 +++++++-----------
 modules/ui/burgs-overview.js  |   2 +-
 modules/ui/layers.js          |   9 ++-
 modules/ui/routes-editor.js   |  19 ++----
 modules/ui/routes-overview.js |  22 ++-----
 modules/ui/zones-editor.js    | 120 +++++++++++++++-------------------
 7 files changed, 102 insertions(+), 138 deletions(-)

diff --git a/index.html b/index.html
index c9ef341e..3e016977 100644
--- a/index.html
+++ b/index.html
@@ -4846,7 +4846,11 @@
         <div id="zonesBottom">
           <button id="zonesEditorRefresh" data-tip="Refresh the Editor" class="icon-cw"></button>
           <button id="zonesEditStyle" data-tip="Edit zones style in Style Editor" class="icon-adjust"></button>
-          <button id="zonesLegend" data-tip="Toggle Legend box" class="icon-list-bullet"></button>
+          <button
+            id="zonesLegend"
+            data-tip="Toggle Legend box (shows all non-hidden zones)"
+            class="icon-list-bullet"
+          ></button>
           <button
             id="zonesPercentage"
             data-tip="Toggle percentage / absolute values views"
diff --git a/modules/ui/burg-editor.js b/modules/ui/burg-editor.js
index a90a11d8..94145e13 100644
--- a/modules/ui/burg-editor.js
+++ b/modules/ui/burg-editor.js
@@ -228,34 +228,26 @@ function editBurg(id) {
     const burgsToRemove = burgsInGroup.filter(b => !(pack.burgs[b].capital || pack.burgs[b].lock));
     const capital = burgsToRemove.length < burgsInGroup.length;
 
-    alertMessage.innerHTML = /* html */ `Are you sure you want to remove ${
-      basic || capital ? "all unlocked elements in the burg group" : "the entire burg group"
-    }?
-      <br />Please note that capital or locked burgs will not be deleted. <br /><br />Burgs to be removed: ${
-        burgsToRemove.length
-      }`;
-    $("#alert").dialog({
-      resizable: false,
+    confirmationDialog({
       title: "Remove burg group",
-      buttons: {
-        Remove: function () {
-          $(this).dialog("close");
-          $("#burgEditor").dialog("close");
-          hideGroupSection();
-          burgsToRemove.forEach(b => removeBurg(b));
+      message: `Are you sure you want to remove ${
+        basic || capital ? "all unlocked elements in the burg group" : "the entire burg group"
+      }?<br />Please note that capital or locked burgs will not be deleted. <br /><br />Burgs to be removed: ${
+        burgsToRemove.length
+      }. This action cannot be reverted`,
+      confirm: "Remove",
+      onConfirm: () => {
+        $("#burgEditor").dialog("close");
+        hideGroupSection();
+        burgsToRemove.forEach(b => removeBurg(b));
 
-          if (!basic && !capital) {
-            // entirely remove group
-            const labelG = document.querySelector("#burgLabels > #" + group.id);
-            const iconG = document.querySelector("#burgIcons > #" + group.id);
-            const anchorG = document.querySelector("#anchors > #" + group.id);
-            if (labelG) labelG.remove();
-            if (iconG) iconG.remove();
-            if (anchorG) anchorG.remove();
-          }
-        },
-        Cancel: function () {
-          $(this).dialog("close");
+        if (!basic && !capital) {
+          const labelG = document.querySelector("#burgLabels > #" + group.id);
+          const iconG = document.querySelector("#burgIcons > #" + group.id);
+          const anchorG = document.querySelector("#anchors > #" + group.id);
+          if (labelG) labelG.remove();
+          if (iconG) iconG.remove();
+          if (anchorG) anchorG.remove();
         }
       }
     });
@@ -509,19 +501,13 @@ function editBurg(id) {
         }
       });
     } else {
-      alertMessage.innerHTML = "Are you sure you want to remove the burg?";
-      $("#alert").dialog({
-        resizable: false,
+      confirmationDialog({
         title: "Remove burg",
-        buttons: {
-          Remove: function () {
-            $(this).dialog("close");
-            removeBurg(id); // see Editors module
-            $("#burgEditor").dialog("close");
-          },
-          Cancel: function () {
-            $(this).dialog("close");
-          }
+        message: "Are you sure you want to remove the burg? <br>This action cannot be reverted",
+        confirm: "Remove",
+        onConfirm: () => {
+          removeBurg(id); // see Editors module
+          $("#burgEditor").dialog("close");
         }
       });
     }
diff --git a/modules/ui/burgs-overview.js b/modules/ui/burgs-overview.js
index f6b09a31..ae4d09dc 100644
--- a/modules/ui/burgs-overview.js
+++ b/modules/ui/burgs-overview.js
@@ -245,7 +245,7 @@ function overviewBurgs(settings = {stateId: null, cultureId: null}) {
 
     confirmationDialog({
       title: "Remove burg",
-      message: "Are you sure you want to remove the burg? This actiove cannot be reverted",
+      message: "Are you sure you want to remove the burg? <br>This action cannot be reverted",
       confirm: "Remove",
       onConfirm: () => {
         removeBurg(burg);
diff --git a/modules/ui/layers.js b/modules/ui/layers.js
index 14d9cbb9..a4801b35 100644
--- a/modules/ui/layers.js
+++ b/modules/ui/layers.js
@@ -1882,13 +1882,16 @@ function toggleZones(event) {
 }
 
 function drawZones() {
-  const zonesHtml = pack.zones.map(drawZone);
+  const filterBy = byId("zonesFilterType").value;
+  const isFiltered = filterBy && filterBy !== "all";
+
+  const zonesHtml = pack.zones.filter(zone => !zone.hidden && (!isFiltered || zone.type === filterBy)).map(drawZone);
   zones.html(zonesHtml.join(""));
 }
 
-function drawZone({i, cells, color}) {
+function drawZone({i, cells, type, color}) {
   const cellsPath = cells.map(cell => "M" + getPackPolygon(cell).join(" ")).join(" ");
-  return `<path id="zone${i}" data-id="${i}" d="${cellsPath}" fill="${color}" />`;
+  return `<path id="zone${i}" data-id="${i}" data-type="${type}" d="${cellsPath}" fill="${color}" />`;
 }
 
 function toggleEmblems(event) {
diff --git a/modules/ui/routes-editor.js b/modules/ui/routes-editor.js
index 82f13e44..4ea119fb 100644
--- a/modules/ui/routes-editor.js
+++ b/modules/ui/routes-editor.js
@@ -389,20 +389,13 @@ function editRoute(id) {
   }
 
   function removeRoute() {
-    alertMessage.innerHTML = "Are you sure you want to remove the route";
-    $("#alert").dialog({
-      resizable: false,
-      width: "22em",
+    confirmationDialog({
       title: "Remove route",
-      buttons: {
-        Remove: function () {
-          Routes.remove(getRoute());
-          $(this).dialog("close");
-          $("#routeEditor").dialog("close");
-        },
-        Cancel: function () {
-          $(this).dialog("close");
-        }
+      message: "Are you sure you want to remove the route? <br>This action cannot be reverted",
+      confirm: "Remove",
+      onConfirm: () => {
+        Routes.remove(getRoute());
+        $("#routeEditor").dialog("close");
       }
     });
   }
diff --git a/modules/ui/routes-overview.js b/modules/ui/routes-overview.js
index 3a8cc5fa..252b2275 100644
--- a/modules/ui/routes-overview.js
+++ b/modules/ui/routes-overview.js
@@ -144,22 +144,14 @@ function overviewRoutes() {
 
   function triggerRouteRemove() {
     const routeId = +this.parentNode.dataset.id;
-
-    alertMessage.innerHTML = `Are you sure you want to remove the route?`;
-    $("#alert").dialog({
-      resizable: false,
-      width: "22em",
+    confirmationDialog({
       title: "Remove route",
-      buttons: {
-        Remove: function () {
-          const route = pack.routes.find(r => r.i === routeId);
-          Routes.remove(route);
-          routesOverviewAddLines();
-          $(this).dialog("close");
-        },
-        Cancel: function () {
-          $(this).dialog("close");
-        }
+      message: "Are you sure you want to remove the route? <br>This action cannot be reverted",
+      confirm: "Remove",
+      onConfirm: () => {
+        const route = pack.routes.find(r => r.i === routeId);
+        Routes.remove(route);
+        routesOverviewAddLines();
       }
     });
   }
diff --git a/modules/ui/zones-editor.js b/modules/ui/zones-editor.js
index 0f6c0226..6c0d927f 100644
--- a/modules/ui/zones-editor.js
+++ b/modules/ui/zones-editor.js
@@ -33,14 +33,17 @@ function editZones() {
   byId("zonesRemove").on("click", toggleEraseMode);
 
   body.on("click", function (ev) {
-    const el = ev.target,
-      cl = el.classList,
-      zone = el.parentNode.dataset.id;
-    if (el.tagName === "FILL-BOX") changeFill(el);
-    else if (cl.contains("culturePopulation")) changePopulation(zone);
-    else if (cl.contains("icon-trash-empty")) zoneRemove(zone);
-    else if (cl.contains("icon-eye")) toggleVisibility(el);
-    else if (cl.contains("icon-pin")) toggleFog(zone, cl);
+    const el = ev.target;
+    const cl = el.classList;
+    const zoneId = el.parentNode.dataset.id;
+    const zone = pack.zones.find(z => "zone" + z.i === zoneId);
+    if (!zone) return;
+
+    if (el.tagName === "FILL-BOX") changeFill(el, zone);
+    else if (cl.contains("zonePopulation")) changePopulation(zone);
+    else if (cl.contains("icon-trash-empty")) zoneRemove(zoneId, zone);
+    else if (cl.contains("icon-eye")) toggleVisibility(zone);
+    else if (cl.contains("icon-pin")) toggleFog(zoneId, cl);
     if (customization) selectZone(el);
   });
 
@@ -54,9 +57,8 @@ function editZones() {
 
   // update type filter with a list of used types
   function updateFilters() {
-    const types = unique(pack.zones.map(zone => zone.type));
-
     const filterSelect = byId("zonesFilterType");
+    const types = unique(pack.zones.map(zone => zone.type));
     const typeToFilterBy = types.includes(zonesFilterType.value) ? zonesFilterType.value : "all";
 
     filterSelect.innerHTML =
@@ -83,7 +85,9 @@ function editZones() {
       )}; Urban population: ${si(urban)}. Click to change`;
       const focused = defs.select("#fog #focusZone" + i).size();
 
-      return `<div class="states" data-id="zone${i}" data-fill="${color}" data-description="${name}"
+      return /* html */ `<div class="states" style="${
+        hidden ? "opacity: 0.5" : null
+      }" data-id="zone${i}" data-fill="${color}" data-description="${name}"
         data-type="${type}" data-cells=${cells.length} data-area=${area} data-population=${population}>
         <fill-box fill="${color}"></fill-box>
         <input data-tip="Zone description. Click and type to change" style="width: 11em" class="zoneName" value="${name}" autocorrect="off" spellcheck="false">
@@ -93,14 +97,12 @@ function editZones() {
         <span data-tip="Zone area" style="padding-right:4px" class="icon-map-o hide"></span>
         <div data-tip="Zone area" class="biomeArea hide">${si(area) + unit}</div>
         <span data-tip="${populationTip}" class="icon-male hide"></span>
-        <div data-tip="${populationTip}" class="culturePopulation hide">${si(population)}</div>
+        <div data-tip="${populationTip}" class="zonePopulation hide pointer">${si(population)}</div>
         <span data-tip="Drag to raise or lower the zone" class="icon-resize-vertical hide"></span>
         <span data-tip="Toggle zone focus" class="icon-pin ${focused ? "" : " inactive"} hide ${
         cells.length ? "" : " placeholder"
       }"></span>
-        <span data-tip="Toggle zone visibility" class="icon-eye ${hidden ? " inactive" : ""} hide ${
-        cells.length ? "" : " placeholder"
-      }"></span>
+        <span data-tip="Toggle zone visibility" class="icon-eye hide ${cells.length ? "" : " placeholder"}"></span>
         <span data-tip="Remove zone" class="icon-trash-empty hide"></span>
       </div>`;
     });
@@ -114,7 +116,7 @@ function editZones() {
       (d3.sum(pack.cells.pop) + d3.sum(pack.burgs.filter(b => !b.removed).map(b => b.population)) * urbanization) *
       populationRate;
     zonesFooterPopulation.dataset.population = totalPop;
-    zonesFooterNumber.innerHTML = `${filteredZones.length} of ${zones.length}`;
+    zonesFooterNumber.innerHTML = `${filteredZones.length} of ${pack.zones.length}`;
     zonesFooterCells.innerHTML = pack.cells.i.length;
     zonesFooterArea.innerHTML = si(totalArea) + unit;
     zonesFooterPopulation.innerHTML = si(totalPop);
@@ -140,15 +142,7 @@ function editZones() {
   }
 
   function filterZonesByType() {
-    const typeToFilterBy = this.value;
-    const zones = Array.from(document.querySelectorAll("#zones > g"));
-
-    for (const zone of zones) {
-      const type = zone.dataset.type;
-      const visible = typeToFilterBy === "all" || type === typeToFilterBy;
-      zone.style.display = visible ? "block" : "none";
-    }
-
+    drawZones();
     zonesEditorAddLines();
   }
 
@@ -313,21 +307,24 @@ function editZones() {
     if (selected) selected.classList.remove("selected");
   }
 
-  function changeFill(el) {
+  function changeFill(el, zone) {
     const fill = el.getAttribute("fill");
     const callback = newFill => {
       el.fill = newFill;
       byId(el.parentNode.dataset.id).setAttribute("fill", newFill);
+      zone.color = newFill;
     };
 
     openPicker(fill, callback);
   }
 
-  function toggleVisibility(el) {
-    const zone = zones.select("#" + el.parentNode.dataset.id);
-    const inactive = zone.style("display") === "none";
-    inactive ? zone.style("display", "block") : zone.style("display", "none");
-    el.classList.toggle("inactive");
+  function toggleVisibility(zone) {
+    const isHidden = Boolean(zone.hidden);
+    if (isHidden) delete zone.hidden;
+    else zone.hidden = true;
+
+    drawZones();
+    zonesEditorAddLines();
   }
 
   function toggleFog(z, cl) {
@@ -347,19 +344,10 @@ function editZones() {
   }
 
   function toggleLegend() {
-    if (legend.selectAll("*").size()) {
-      clearLegend();
-      return;
-    } // hide legend
-    const data = [];
-
-    zones.selectAll("g").each(function () {
-      const id = this.dataset.id;
-      const description = this.dataset.description;
-      const fill = this.getAttribute("fill");
-      data.push([id, fill, description]);
-    });
-
+    const filterBy = byId("zonesFilterType").value;
+    const isFiltered = filterBy && filterBy !== "all";
+    const visibleZones = pack.zones.filter(zone => !zone.hidden && (!isFiltered || zone.type === filterBy));
+    const data = visibleZones.map(({i, name, color}) => ["zone" + i, color, name]);
     drawLegend("Zones", data);
   }
 
@@ -373,8 +361,7 @@ function editZones() {
       body.querySelectorAll(":scope > div").forEach(function (el) {
         el.querySelector(".stateCells").innerHTML = rn((+el.dataset.cells / totalCells) * 100, 2) + "%";
         el.querySelector(".biomeArea").innerHTML = rn((+el.dataset.area / totalArea) * 100, 2) + "%";
-        el.querySelector(".culturePopulation").innerHTML =
-          rn((+el.dataset.population / totalPopulation) * 100, 2) + "%";
+        el.querySelector(".zonePopulation").innerHTML = rn((+el.dataset.population / totalPopulation) * 100, 2) + "%";
       });
     } else {
       body.dataset.type = "absolute";
@@ -421,22 +408,13 @@ function editZones() {
   }
 
   function changePopulation(zone) {
-    const dataCells = zones.select("#" + zone).attr("data-cells");
-    const cells = dataCells
-      ? dataCells
-          .split(",")
-          .map(i => +i)
-          .filter(i => pack.cells.h[i] >= 20)
-      : [];
-    if (!cells.length) {
-      tip("Zone does not have any land cells, cannot change population", false, "error");
-      return;
-    }
-    const burgs = pack.burgs.filter(b => !b.removed && cells.includes(b.cell));
+    const landCells = zone.cells.filter(i => pack.cells.h[i] >= 20);
+    if (!landCells.length) return tip("Zone does not have any land cells, cannot change population", false, "error");
 
-    const rural = rn(d3.sum(cells.map(i => pack.cells.pop[i])) * populationRate);
+    const burgs = pack.burgs.filter(b => !b.removed && landCells.includes(b.cell));
+    const rural = rn(d3.sum(landCells.map(i => pack.cells.pop[i])) * populationRate);
     const urban = rn(
-      d3.sum(cells.map(i => pack.cells.burg[i]).map(b => pack.burgs[b].population)) * populationRate * urbanization
+      d3.sum(landCells.map(i => pack.cells.burg[i]).map(b => pack.burgs[b].population)) * populationRate * urbanization
     );
     const total = rural + urban;
     const l = n => Number(n).toLocaleString();
@@ -478,12 +456,12 @@ function editZones() {
     function applyPopulationChange() {
       const ruralChange = ruralPop.value / rural;
       if (isFinite(ruralChange) && ruralChange !== 1) {
-        cells.forEach(i => (pack.cells.pop[i] *= ruralChange));
+        landCells.forEach(i => (pack.cells.pop[i] *= ruralChange));
       }
       if (!isFinite(ruralChange) && +ruralPop.value > 0) {
         const points = ruralPop.value / populationRate;
-        const pop = rn(points / cells.length);
-        cells.forEach(i => (pack.cells.pop[i] = pop));
+        const pop = rn(points / landCells.length);
+        landCells.forEach(i => (pack.cells.pop[i] = pop));
       }
 
       const urbanChange = urbanPop.value / urban;
@@ -500,9 +478,17 @@ function editZones() {
     }
   }
 
-  function zoneRemove(zone) {
-    zones.select("#" + zone).remove();
-    unfog("focusZone" + zone);
-    zonesEditorAddLines();
+  function zoneRemove(zoneId, zone) {
+    confirmationDialog({
+      title: "Remove zone",
+      message: "Are you sure you want to remove the zone? <br>This action cannot be reverted",
+      confirm: "Remove",
+      onConfirm: () => {
+        pack.zones = pack.zones.filter(z => z.i !== zone.i);
+        zones.select("#" + zoneId).remove();
+        unfog("focusZone" + zoneId);
+        zonesEditorAddLines();
+      }
+    });
   }
 }