From 4a079acf5629445eebc5be812feee920773513f1 Mon Sep 17 00:00:00 2001
From: carnotcrash <108499248+carnotcrash@users.noreply.github.com>
Date: Sun, 25 Sep 2022 21:30:49 +1000
Subject: [PATCH] Markers full stops + some lil changes. (#875)

Grammar policing. Also slight modifications to sofronaspe's sacred tree places (idk what they are called collectively lol) to be slightly more grammatically correct, extending it to sacred peaks, Hot Spring variants, and maybe some other stuff I've forgotten. I have some more ideas for markers as I personally find them super interesting and great for adding depth to a world, just need to gather my thoughts and maybe actully learn how to code.
---
 modules/markers-generator.js | 69 +++++++++++++++++++-----------------
 1 file changed, 36 insertions(+), 33 deletions(-)

diff --git a/modules/markers-generator.js b/modules/markers-generator.js
index 88dc5285..40d3df45 100644
--- a/modules/markers-generator.js
+++ b/modules/markers-generator.js
@@ -167,7 +167,7 @@ window.Markers = (function () {
     const proper = Names.getCulture(cells.culture[cell]);
     const name = P(0.3) ? "Mount " + proper : Math.random() > 0.3 ? proper + " Volcano" : proper;
     const status = P(0.6) ? "Dormant" : Math.random() > 0.6 ? "Active" : "Erupting";
-    notes.push({id, name, legend: `${status} volcano. Height: ${getFriendlyHeight(cells.p[cell])}`});
+    notes.push({id, name, legend: `${status} volcano. Height: ${getFriendlyHeight(cells.p[cell])}.`});
   }
 
   function listHotSprings({cells}) {
@@ -179,7 +179,8 @@ window.Markers = (function () {
 
     const proper = Names.getCulture(cells.culture[cell]);
     const temp = convertTemperature(gauss(35, 15, 20, 100));
-    notes.push({id, name: proper + " Hot Springs", legend: `A hot springs area. Average temperature: ${temp}`});
+    const status = P(0.6) ? "geothermal" : Math.random() > 0.6 ? "springwater" : "natural";
+    notes.push({id, name: proper + " Hot Springs", legend: `A ${status} hot springs area. Average temperature: ${temp}.`});
   }
 
   function listMines({cells}) {
@@ -194,7 +195,7 @@ window.Markers = (function () {
     const burg = pack.burgs[cells.burg[cell]];
     const name = `${burg.name} — ${resource} mining town`;
     const population = rn(burg.population * populationRate * urbanization);
-    const legend = `${burg.name} is a mining town of ${population} people just nearby the ${resource} mine`;
+    const legend = `${burg.name} is a mining town of ${population} people just nearby the ${resource} mine.`;
     notes.push({id, name, legend});
   }
 
@@ -222,15 +223,15 @@ window.Markers = (function () {
       weathered: 1
     };
     const barriers = [
-      "collapse during the flood",
+      "its collapse during the flood",
       "being rumoured to attract trolls",
       "the drying up of local trade",
       "banditry infested the area",
       "the old waypoints crumbled"
     ];
     const legend = P(0.7)
-      ? `A ${rw(weightedAdjectives)} bridge spans over the ${riverName} near ${burg.name}`
-      : `An old crossing of the ${riverName}, rarely used since ${ra(barriers)}`;
+      ? `A ${rw(weightedAdjectives)} bridge spans over the ${riverName} near ${burg.name}.`
+      : `An old crossing of the ${riverName}, rarely used since ${ra(barriers)}.`;
 
     notes.push({id, name, legend});
   }
@@ -475,7 +476,7 @@ window.Markers = (function () {
     const meal = isAnimalThemed && P(0.3) ? animal : ra(courses);
     const course = `${ra(methods)} ${meal}`.toLowerCase();
     const drink = `${P(0.5) ? ra(types) : ra(colors)} ${ra(drinks)}`.toLowerCase();
-    const legend = `A big and famous roadside ${typeName}. Delicious ${course} with ${drink} is served here`;
+    const legend = `A big and famous roadside ${typeName}. Delicious ${course} with ${drink} is served here.`;
     notes.push({id, name: "The " + name, legend});
   }
 
@@ -487,7 +488,7 @@ window.Markers = (function () {
     const {cells} = pack;
 
     const proper = cells.burg[cell] ? pack.burgs[cells.burg[cell]].name : Names.getCulture(cells.culture[cell]);
-    notes.push({id, name: getAdjective(proper) + " Lighthouse" + name, legend: `A lighthouse to serve as a beacon for ships in the open sea`});
+    notes.push({id, name: getAdjective(proper) + " Lighthouse" + name, legend: `A lighthouse to serve as a beacon for ships in the open sea.`});
   }
 
   function listWaterfalls({cells}) {
@@ -498,12 +499,12 @@ window.Markers = (function () {
     const {cells} = pack;
 
     const descriptions = [
-      "A gorgeous waterfall flows here",
-      "The rapids of an exceptionally beautiful waterfall",
-      "An impressive waterfall has cut through the land",
-      "The cascades of a stunning waterfall",
-      "A river drops down from a great height forming a wonderous waterfall",
-      "A breathtaking waterfall cuts through the landscape"
+      "A gorgeous waterfall flows here.",
+      "The rapids of an exceptionally beautiful waterfall.",
+      "An impressive waterfall has cut through the land.",
+      "The cascades of a stunning waterfall.",
+      "A river drops down from a great height forming a wonderous waterfall.",
+      "A breathtaking waterfall cuts through the landscape."
     ];
 
     const proper = cells.burg[cell] ? pack.burgs[cells.burg[cell]].name : Names.getCulture(cells.culture[cell]);
@@ -522,7 +523,7 @@ window.Markers = (function () {
     const campaign = ra(state.campaigns);
     const date = generateDate(campaign.start, campaign.end);
     const name = Names.getCulture(cells.culture[cell]) + " Battlefield";
-    const legend = `A historical battle of the ${campaign.name}. \r\nDate: ${date} ${options.era}`;
+    const legend = `A historical battle of the ${campaign.name}. \r\nDate: ${date} ${options.era}.`;
     notes.push({id, name, legend});
   }
 
@@ -552,7 +553,8 @@ window.Markers = (function () {
 
     const name = `${lake.name} Monster`;
     const length = gauss(10, 5, 5, 100);
-    const legend = `Rumors say a relic monster of ${length} ${heightUnit.value} long inhabits ${lake.name} Lake. Truth or lie, folks are afraid to fish in the lake`;
+    const subjects = ["Locals", "Elders", "Inscriptions", "Tipplers", "Legends", "Whispers", "Rumors", "Journeying folk", "Tales"];
+    const legend = `${ra(subjects)} say a relic monster of ${length} ${heightUnit.value} long inhabits ${lake.name} Lake. Truth or lie, folks are afraid to fish in the lake.`;
     notes.push({id, name, legend});
   }
 
@@ -563,7 +565,7 @@ window.Markers = (function () {
   function addSeaMonster(id, cell) {
     const name = `${Names.getCultureShort(0)} Monster`;
     const length = gauss(25, 10, 10, 100);
-    const legend = `Old sailors tell stories of a gigantic sea monster inhabiting these dangerous waters. Rumors say it can be ${length} ${heightUnit.value} long`;
+    const legend = `Old sailors tell stories of a gigantic sea monster inhabiting these dangerous waters. Rumors say it can be ${length} ${heightUnit.value} long.`;
     notes.push({id, name, legend});
   }
 
@@ -627,7 +629,7 @@ window.Markers = (function () {
     const monster = ra(species);
     const toponym = Names.getCulture(cells.culture[cell]);
     const name = `${toponym} ${monster}`;
-    const legend = `${ra(subjects)} speak of a ${ra(adjectives)} ${monster} who inhabits ${toponym} hills and ${ra(modusOperandi)}`;
+    const legend = `${ra(subjects)} speak of a ${ra(adjectives)} ${monster} who inhabits ${toponym} hills and ${ra(modusOperandi)}.`;
     notes.push({id, name, legend});
   }
 
@@ -640,9 +642,10 @@ window.Markers = (function () {
     const {cells, cultures} = pack;
 
     const culture = cells.c[cell].map(c => cells.culture[c]).find(c => c);
+    const religion = cells.religion[cell];
     const name = `${Names.getCulture(culture)} Mountain`;
     const height = getFriendlyHeight(cells.p[cell]);
-    const legend = `A sacred mountain of ${cultures[culture].name} culture. Height: ${height}`;
+    const legend = `A sacred mountain of ${religions[religion].name}. Height: ${height}.`;
     notes.push({id, name, legend});
   }
 
@@ -657,7 +660,7 @@ window.Markers = (function () {
     const culture = cells.culture[cell];
     const religion = cells.religion[cell];
     const name = `${Names.getCulture(culture)} Forest`;
-    const legend = `A forest sacred to the followers of ${religions[religion].name}`;
+    const legend = `A forest sacred to local ${religions[religion].name}.`;
     notes.push({id, name, legend});
   }
 
@@ -672,7 +675,7 @@ window.Markers = (function () {
     const culture = cells.culture[cell];
     const religion = cells.religion[cell];
     const name = `${Names.getCulture(culture)} Pinery`;
-    const legend = `A pinery sacred to the followers of ${religions[religion].name}`;
+    const legend = `A pinery sacred to local ${religions[religion].name}.`;
     notes.push({id, name, legend});
   }
 
@@ -687,7 +690,7 @@ window.Markers = (function () {
     const culture = cells.culture[cell];
     const religion = cells.religion[cell];
     const name = `${Names.getCulture(culture)} Palm Grove`;
-    const legend = `A palm grove sacred to the followers of ${religions[religion].name}`;
+    const legend = `A palm grove sacred to local ${religions[religion].name}.`;
     notes.push({id, name, legend});
   }
 
@@ -748,7 +751,7 @@ window.Markers = (function () {
         ? "swamp"
         : "angry";
     const name = `${Names.getCulture(culture)} ${ra(animals)}`;
-    const legend = `A gang of ${locality} ${rw(types)}`;
+    const legend = `A gang of ${locality} ${rw(types)}.`;
     notes.push({id, name, legend});
   }
 
@@ -759,7 +762,7 @@ window.Markers = (function () {
 
   function addPirates(id, cell) {
     const name = `Pirates`;
-    const legend = `Pirate ships have been spotted in these waters`;
+    const legend = `Pirate ships have been spotted in these waters.`;
     notes.push({id, name, legend});
   }
 
@@ -816,7 +819,7 @@ window.Markers = (function () {
 
     const ruinType = ra(types);
     const name = `Ruined ${ruinType}`;
-    const legend = `Ruins of an ancient ${ruinType.toLowerCase()}. Untold riches may lie within`;
+    const legend = `Ruins of an ancient ${ruinType.toLowerCase()}. Untold riches may lie within.`;
     notes.push({id, name, legend});
   }
 
@@ -829,7 +832,7 @@ window.Markers = (function () {
 
     const adjective = ra(adjectives);
     const name = `Travelling ${adjective} Circus`;
-    const legend = `Roll up, roll up, this ${adjective.toLowerCase()} circus is here for a limited time only`;
+    const legend = `Roll up, roll up, this ${adjective.toLowerCase()} circus is here for a limited time only.`;
     notes.push({id, name, legend});
   }
 
@@ -848,7 +851,7 @@ window.Markers = (function () {
     const virtue = ra(virtues);
 
     const name = `${burgName} ${type}`;
-    const legend = `Warriors from around the land gather for a ${type.toLowerCase()} of ${virtue} in ${burgName}, with fame, fortune and favour on offer to the victor`;
+    const legend = `Warriors from around the land gather for a ${type.toLowerCase()} of ${virtue} in ${burgName}, with fame, fortune and favour on offer to the victor.`;
     notes.push({id, name, legend});
   }
 
@@ -861,7 +864,7 @@ window.Markers = (function () {
 
     const name = `Minor Jetty`;
     const riverName = river ? `${river.name} ${river.type}` : "river";
-    const legend = `A small location along the ${riverName} to launch boats from sits here, along with a weary looking owner, willing to sell passage along the river`;
+    const legend = `A small location along the ${riverName} to launch boats from sits here, along with a weary looking owner, willing to sell passage along the river.`;
     notes.push({id, name, legend});
   }
 
@@ -926,7 +929,7 @@ window.Markers = (function () {
     const animalChoice = ra(animals);
 
     const name = `${animalChoice} migration`;
-    const legend = `A huge group of ${animalChoice.toLowerCase()} are migrating, whether part of their annual routine, or something more extraordinary`;
+    const legend = `A huge group of ${animalChoice.toLowerCase()} are migrating, whether part of their annual routine, or something more extraordinary.`;
     notes.push({id, name, legend});
   }
 
@@ -944,7 +947,7 @@ window.Markers = (function () {
     const name = `${burgName} ${socialType}`;
     const legend = `A ${socialType} has been organised at ${burgName} as a chance to gather the ${ra(
       people
-    )} of the area together to be merry, make alliances and scheme around the crisis`;
+    )} of the area together to be merry, make alliances and scheme around the crisis.`;
     notes.push({id, name, legend});
   }
 
@@ -957,7 +960,7 @@ window.Markers = (function () {
 
     const mirageAdjective = ra(adjectives);
     const name = `${mirageAdjective} mirage`;
-    const legend = `This ${mirageAdjective.toLowerCase()} mirage has been luring travellers out of their way for eons`;
+    const legend = `This ${mirageAdjective.toLowerCase()} mirage has been luring travellers out of their way for eons.`;
     notes.push({id, name, legend});
   }
 
@@ -1013,7 +1016,7 @@ window.Markers = (function () {
     const burgName = burgs[cells.burg[cell]].name;
 
     const name = `${burgName} Portal`;
-    const legend = `An element of the magic portal system connecting major cities. The portals were installed centuries ago, but still work fine`;
+    const legend = `An element of the magic portal system connecting major cities. The portals were installed centuries ago, but still work fine.`;
     notes.push({id, name, legend});
   }
 
@@ -1028,7 +1031,7 @@ window.Markers = (function () {
       "all known nearby beings to flee in terror",
       "cracks in reality itself to form",
       "swarms of foes to spill forth",
-      "the life of nearby plants to wither and decay",
+      "nearby plants to wither and decay",
       "an emmissary to step through with an all-powerful relic"
     ];