backups/Fantasy-Map-Generator
1
0
Fork 0
mirror of https://github.com/Azgaar/Fantasy-Map-Generator.git synced 2025-12-17 09:41:24 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed note-editor bug (#404)

Browse source 
* Fixed note-editor bug that would raise error on edit when no notes are present

* Added additional check so that no errors would be thrown when no notes are present
This commit is contained in:
mivasiliauskas 2020-02-15 11:20:53 +02:00 • committed by GitHub
parent 4bef159546
commit 7c74c3d29f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
modules/ui/notes-editor.js
View file

@ -6,7 +6,7 @@ function editNotes(id, name) {
for (const note of notes) {select.options.add(new Option(note.id, note.id));} for (const note of notes) {select.options.add(new Option(note.id, note.id));}
// select an object // select an object
if (notes.length) { if (notes.length || id) {
if (!id) id = notes[0].id; if (!id) id = notes[0].id;
let note = notes.find(note => note.id === id); let note = notes.find(note => note.id === id);
if (note === undefined) { if (note === undefined) {
@ -19,10 +19,9 @@ function editNotes(id, name) {
notesName.value = note.name; notesName.value = note.name;
notesText.value = note.legend; notesText.value = note.legend;
} else { } else {
if (!notes.length) { const value = "There are no added notes. Click on element (e.g. label) and add a free text note";
const value = "There are no added notes. Click on element (e.g. label) and add a free text note"; document.getElementById("notesText").value = value;
document.getElementById("notesText").value = value; document.getElementById("notesName").value = "";
}
} }
// open a dialog // open a dialog
@ -54,12 +53,14 @@ function editNotes(id, name) {
function changeName() { function changeName() {
const id = document.getElementById("notesSelect").value; const id = document.getElementById("notesSelect").value;
const note = notes.find(note => note.id === id); const note = notes.find(note => note.id === id);
if (!note) return;
note.name = this.value; note.name = this.value;
} }
function changeText() { function changeText() {
const id = document.getElementById("notesSelect").value; const id = document.getElementById("notesSelect").value;
const note = notes.find(note => note.id === id); const note = notes.find(note => note.id === id);
if (!note) return;
note.legend = this.value; note.legend = this.value;
} }