backups/Fantasy-Map-Generator
1
0
Fork 0
mirror of https://github.com/Azgaar/Fantasy-Map-Generator.git synced 2025-12-18 18:11:24 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

changed select eventListeners from "input" to "change" (#318)

Browse source 
Although not an issue for most modern browsers, Microsoft Edge does not register "input" events on select Elements.

Bugfix for issue #315. https://github.com/Azgaar/Fantasy-Map-Generator/issues/315
This commit is contained in:
floookay 2019-10-03 13:36:10 +02:00 • committed by Azgaar
parent 8ff1fe46b8
commit b4dcfec86e
3 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
modules/ui/provinces-editor.js
View file

@ -45,7 +45,7 @@ function editProvinces() {
if (cl.contains("icon-trash-empty")) removeProvince(p); if (cl.contains("icon-trash-empty")) removeProvince(p);
}); });
body.addEventListener("input", function(ev) { body.addEventListener("change", function(ev) {
const el = ev.target, cl = el.classList, line = el.parentNode, p = +line.dataset.id; const el = ev.target, cl = el.classList, line = el.parentNode, p = +line.dataset.id;
if (cl.contains("cultureBase")) changeCapital(p, line, el.value); if (cl.contains("cultureBase")) changeCapital(p, line, el.value);
}); });

2
modules/ui/religions-editor.js
View file

@ -120,7 +120,7 @@ function editReligions() {
body.querySelectorAll("div.states").forEach(el => el.addEventListener("click", selectReligionOnLineClick)); body.querySelectorAll("div.states").forEach(el => el.addEventListener("click", selectReligionOnLineClick));
body.querySelectorAll("rect.zoneFill").forEach(el => el.addEventListener("click", religionChangeColor)); body.querySelectorAll("rect.zoneFill").forEach(el => el.addEventListener("click", religionChangeColor));
body.querySelectorAll("div > input.religionName").forEach(el => el.addEventListener("input", religionChangeName)); body.querySelectorAll("div > input.religionName").forEach(el => el.addEventListener("input", religionChangeName));
body.querySelectorAll("div > select.religionType").forEach(el => el.addEventListener("input", religionChangeType)); body.querySelectorAll("div > select.religionType").forEach(el => el.addEventListener("change", religionChangeType));
body.querySelectorAll("div > input.religionForm").forEach(el => el.addEventListener("input", religionChangeForm)); body.querySelectorAll("div > input.religionForm").forEach(el => el.addEventListener("input", religionChangeForm));
body.querySelectorAll("div > input.religionDeity").forEach(el => el.addEventListener("input", religionChangeDeity)); body.querySelectorAll("div > input.religionDeity").forEach(el => el.addEventListener("input", religionChangeDeity));
body.querySelectorAll("div > span.icon-arrows-cw").forEach(el => el.addEventListener("click", regenerateDeity)); body.querySelectorAll("div > span.icon-arrows-cw").forEach(el => el.addEventListener("click", regenerateDeity));

6
modules/ui/states-editor.js
View file

@ -53,10 +53,14 @@ function editStates() {
const el = ev.target, cl = el.classList, line = el.parentNode, state = +line.dataset.id; const el = ev.target, cl = el.classList, line = el.parentNode, state = +line.dataset.id;
if (cl.contains("stateCapital")) stateChangeCapitalName(state, line, el.value); else if (cl.contains("stateCapital")) stateChangeCapitalName(state, line, el.value); else
if (cl.contains("cultureType")) stateChangeType(state, line, el.value); else if (cl.contains("cultureType")) stateChangeType(state, line, el.value); else
if (cl.contains("stateCulture")) stateChangeCulture(state, line, el.value); else
if (cl.contains("statePower")) stateChangeExpansionism(state, line, el.value); if (cl.contains("statePower")) stateChangeExpansionism(state, line, el.value);
}); });
body.addEventListener("change", function(ev) {
const el = ev.target, cl = el.classList, line = el.parentNode, state = +line.dataset.id;
if (cl.contains("stateCulture")) stateChangeCulture(state, line, el.value);
});
function refreshStatesEditor() { function refreshStatesEditor() {
BurgsAndStates.collectStatistics(); BurgsAndStates.collectStatistics();
statesEditorAddLines(); statesEditorAddLines();