fix: improve comments for clarity and update type imports for consistency

This commit is contained in:
Azgaar 2026-03-11 01:17:36 +01:00
parent 3c7b6fffef
commit fae0bd1085
6 changed files with 37 additions and 23 deletions

View file

@ -453,7 +453,7 @@ class EmblemGeneratorModule {
// Size selection - must use sequential P() calls to match original behavior
if (P(0.1)) size = "-small";
// biome-ignore lint/suspicious/noDuplicateElseIf: <explanation>
// biome-ignore lint/suspicious/noDuplicateElseIf: sequential probability selection requires repeated else-if with same condition
else if (P(0.1)) size = "-smaller";
else if (P(0.01)) size = "-big";
else if (P(0.005)) size = "-smallest";
@ -469,11 +469,11 @@ class EmblemGeneratorModule {
if (P(0.2)) {
t1 = "gules";
t2 = "or";
// biome-ignore lint/suspicious/noDuplicateElseIf: <explanation>
// biome-ignore lint/suspicious/noDuplicateElseIf: sequential probability selection requires repeated else-if with same condition
} else if (P(0.2)) {
t1 = "argent";
t2 = "sable";
// biome-ignore lint/suspicious/noDuplicateElseIf: <explanation>
// biome-ignore lint/suspicious/noDuplicateElseIf: sequential probability selection requires repeated else-if with same condition
} else if (P(0.2)) {
t1 = "azure";
t2 = "argent";
@ -482,7 +482,7 @@ class EmblemGeneratorModule {
if (P(0.3)) {
t1 = "gules";
t2 = "argent";
// biome-ignore lint/suspicious/noDuplicateElseIf: <explanation>
// biome-ignore lint/suspicious/noDuplicateElseIf: sequential probability selection requires repeated else-if with same condition
} else if (P(0.3)) {
t1 = "argent";
t2 = "sable";

View file

@ -430,7 +430,7 @@ class MilitaryModule {
nodes.forEach((node) => {
tree.remove(node);
const overlap = tree.find(node.x, node.y, 20);
if (overlap && overlap.t && mergeable(node, overlap)) {
if (overlap?.t && mergeable(node, overlap)) {
merge(node, overlap);
return;
}

View file

@ -318,7 +318,7 @@ class ProvinceModule {
if (singleIsle) return "Island";
if (isleGroup) return "Islands";
if (colony) return "Colony";
return rw(this.forms["Wild"]);
return rw(this.forms.Wild);
})();
const fullName = `${name} ${formName}`;