backups/Fantasy-Map-Generator
1
0
Fork 0
mirror of https://github.com/Azgaar/Fantasy-Map-Generator.git synced 2025-12-19 02:21:24 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(burgs): centralize burg management logic in Burgs module

Browse source 
Moved burg-related functions like `removeBurg`, `changeGroup`, and `toggleCapital` into the Burgs module to improve code organization and maintainability. Updated all references to these functions across the codebase. This change reduces duplication and ensures consistent behavior for burg management operations.
This commit is contained in:
Azgaar 2025-04-17 01:03:14 +02:00
parent a5939be6e2
commit fd9e010153
12 changed files with 213 additions and 215 deletions
Download patch file Download diff file Expand all files Collapse all files

36
modules/dynamic/editors/states-editor.js
View file

@ -603,7 +603,7 @@ function stateRemove(stateId) {
burg.state = 0;
if (burg.capital) {
burg.capital = 0;
moveBurgToGroup(burg.i, "town");
Burgs.changeGroup(burg);
}
}
});
@ -1181,30 +1181,30 @@ function addState() {
if (cells.h[center] < 20)
return tip("You cannot place state into the water. Please click on a land cell", false, "error");
let burg = cells.burg[center];
if (burg && burgs[burg].capital)
let burgId = cells.burg[center];
if (burgId && burgs[burgId].capital)
return tip("Existing capital cannot be selected as a new state capital! Select other cell", false, "error");
if (!burg) burg = Burgs.add(point);
if (!burgId) burgId = Burgs.add(point);
const oldState = cells.state[center];
const newState = states.length;
// turn burg into a capital
burgs[burg].capital = 1;
burgs[burg].state = newState;
moveBurgToGroup(burg, "city");
burgs[burgId].capital = 1;
burgs[burgId].state = newState;
Burgs.changeGroup(burgs[burgId]);
if (d3.event.shiftKey === false) exitAddStateMode();
const culture = cells.culture[center];
const basename = center % 5 === 0 ? burgs[burg].name : Names.getCulture(culture);
const basename = center % 5 === 0 ? burgs[burgId].name : Names.getCulture(culture);
const name = Names.getState(basename, culture);
const color = getRandomColor();
// generate emblem
const cultureType = pack.cultures[culture].type;
const coa = COA.generate(burgs[burg].coa, 0.4, null, cultureType);
const coa = COA.generate(burgs[burgId].coa, 0.4, null, cultureType);
coa.shield = COA.getShield(culture, null);
// update diplomacy and reverse relations
@ -1244,7 +1244,7 @@ function addState() {
provinces: [],
color,
expansionism: 0.5,
capital: burg,
capital: burgId,
type: "Generic",
center,
culture,
@ -1380,19 +1380,19 @@ function openStateMergeDialog() {
});
// reassing burgs
pack.burgs.forEach(b => {
if (statesToMerge.includes(b.state)) {
if (b.capital) {
moveBurgToGroup(b.i, "town");
b.capital = 0;
pack.burgs.forEach(burg => {
if (statesToMerge.includes(burg.state)) {
if (burg.capital) {
burg.capital = 0;
Burgs.changeGroup(burg);
}
b.state = rulingStateId;
burg.state = rulingStateId;
}
});
// reassign provinces
pack.provinces.forEach((p, i) => {
if (statesToMerge.includes(p.state)) p.state = rulingStateId;
pack.provinces.forEach(province => {
if (statesToMerge.includes(province.state)) province.state = rulingStateId;
});
// reassing cells