fix lints revealed by tracing change

<https://github.com/tokio-rs/tracing/pull/3108> changes #[instrument] so
that several lints that were previously hidden on instrumented functions
are now visible.

src/api/client_server/media.rs

@@ -320,7 +320,7 @@ async fn get_remote_content_via_legacy_api(
 }
 
 #[tracing::instrument]
-pub(crate) async fn get_remote_content(
+async fn get_remote_content(
     mxc: &MxcData<'_>,
 ) -> Result<RemoteResponse, Error> {
     let fed_result = get_remote_content_via_federation_api(mxc).await;
@@ -785,7 +785,7 @@ async fn get_remote_thumbnail_via_legacy_api(
 }
 
 #[tracing::instrument]
-pub(crate) async fn get_remote_thumbnail(
+async fn get_remote_thumbnail(
     server_name: &ruma::ServerName,
     request: authenticated_media_fed::get_content_thumbnail::v1::Request,
 ) -> Result<RemoteResponse, Error> {

src/api/client_server/membership.rs

@@ -1521,7 +1521,7 @@ pub(crate) async fn leave_room(
                 services().rooms.state_cache.update_membership(
                     room_id,
                     user_id,
-                    MembershipState::Leave,
+                    &MembershipState::Leave,
                     user_id,
                     None,
                     true,
@@ -1575,7 +1575,7 @@ pub(crate) async fn leave_room(
         services().rooms.state_cache.update_membership(
             room_id,
             user_id,
-            MembershipState::Leave,
+            &MembershipState::Leave,
             user_id,
             last_state,
             true,

src/api/client_server/sync/v3.rs

@@ -915,6 +915,7 @@ async fn load_joined_room(
     })
 }
 
+#[allow(clippy::too_many_lines)]
 #[tracing::instrument(skip_all)]
 async fn collect_left_rooms(
     ctx: &SyncContext<'_>,

src/api/server_server.rs

@@ -147,6 +147,7 @@ pub(crate) enum AllowLoopbackRequests {
     No,
 }
 
+#[allow(clippy::too_many_lines)]
 #[tracing::instrument(skip(request, log_error, allow_loopback), fields(url))]
 pub(crate) async fn send_request<T>(
     destination: &ServerName,
@@ -1883,7 +1884,7 @@ pub(crate) async fn create_invite_route(
         services().rooms.state_cache.update_membership(
             &body.room_id,
             &invited_user,
-            MembershipState::Invite,
+            &MembershipState::Invite,
             &sender,
             Some(invite_state),
             true,