From 4e6c8451caf24e2b000e921567d2382e879a87a8 Mon Sep 17 00:00:00 2001 From: Charles Hall Date: Tue, 14 May 2024 17:45:58 -0700 Subject: [PATCH] enable `match_bool` lint --- Cargo.toml | 1 + src/service/admin.rs | 9 +++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 965f66cd..341e434a 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -47,6 +47,7 @@ lossy_float_literal = "warn" manual_let_else = "warn" manual_string_new = "warn" map_unwrap_or = "warn" +match_bool = "warn" mem_forget = "warn" missing_assert_message = "warn" mod_module_files = "warn" diff --git a/src/service/admin.rs b/src/service/admin.rs index 2da95e13..8e33bdbb 100644 --- a/src/service/admin.rs +++ b/src/service/admin.rs @@ -764,13 +764,14 @@ impl Service { if !force { user_ids.retain(|&user_id| match services().users.is_admin(user_id) { - Ok(is_admin) => match is_admin { - true => { + Ok(is_admin) => { + if is_admin { admins.push(user_id.localpart()); false + } else { + true } - false => true, - }, + } Err(_) => false, }) }