From 60b89aba78667bf689605972f0fd1e1caa4a9f53 Mon Sep 17 00:00:00 2001
From: Charles Hall <charles@computer.surgery>
Date: Mon, 15 Jul 2024 17:56:43 -0700
Subject: [PATCH] fix api/client_server/session events

And also add a new event for logging out to match the one for logging in
because why not.
---
 src/api/client_server/session.rs | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/api/client_server/session.rs b/src/api/client_server/session.rs
index 123a66c7..188397cf 100644
--- a/src/api/client_server/session.rs
+++ b/src/api/client_server/session.rs
@@ -79,7 +79,7 @@ pub(crate) async fn login_route(
                 } else if let Some(user) = user {
                     UserId::parse(user)
                 } else {
-                    warn!("Bad login type: {:?}", &body.login_info);
+                    warn!(kind = ?body.login_info, "Bad login kind");
                     return Err(Error::BadRequest(
                         ErrorKind::forbidden(),
                         "Bad login type.",
@@ -184,7 +184,7 @@ pub(crate) async fn login_route(
                 } else if let Some(user) = user {
                     UserId::parse(user)
                 } else {
-                    warn!("Bad login type: {:?}", &body.login_info);
+                    warn!(kind = ?body.login_info, "Bad login kind");
                     return Err(Error::BadRequest(
                         ErrorKind::forbidden(),
                         "Bad login type.",
@@ -214,7 +214,7 @@ pub(crate) async fn login_route(
             user_id
         }
         _ => {
-            warn!("Unsupported or unknown login type: {:?}", &body.login_info);
+            warn!(kind = ?body.login_info, "Unsupported or unknown login kind");
             return Err(Error::BadRequest(
                 ErrorKind::Unknown,
                 "Unsupported login type.",
@@ -250,7 +250,7 @@ pub(crate) async fn login_route(
         )?;
     }
 
-    info!("{} logged in", user_id);
+    info!(%user_id, %device_id, "User logged in");
 
     // Homeservers are still required to send the `home_server` field
     #[allow(deprecated)]
@@ -292,6 +292,8 @@ pub(crate) async fn logout_route(
 
     services().users.remove_device(sender_user, sender_device)?;
 
+    info!(user_id = %sender_user, device_id = %sender_device, "User logged out");
+
     Ok(Ra(logout::v3::Response::new()))
 }