enable string_add lint

Cargo.toml

@@ -50,6 +50,7 @@ rest_pat_in_fully_bound_structs = "warn"
 same_name_method = "warn"
 semicolon_inside_block = "warn"
 str_to_string = "warn"
+string_add = "warn"
 string_lit_chars_any = "warn"
 string_to_string = "warn"
 suspicious_xor_used_as_pow = "warn"

src/api/appservice_server.rs

@@ -44,7 +44,7 @@ where
     };
 
     parts.path_and_query = Some(
-        (old_path_and_query + symbol + "access_token=" + hs_token)
+        format!("{old_path_and_query}{symbol}access_token={hs_token}")
             .parse()
             .unwrap(),
     );

src/api/client_server/media.rs

@@ -43,7 +43,7 @@ pub(crate) async fn create_content_route(
             mxc.clone(),
             body.filename
                 .as_ref()
-                .map(|filename| "inline; filename=".to_owned() + filename)
+                .map(|filename| format!("inline; filename={filename}"))
                 .as_deref(),
             body.content_type.as_deref(),
             &body.file,

src/api/client_server/sync.rs

@@ -1598,15 +1598,15 @@ pub(crate) async fn sync_events_v4_route(
         let name = match &*heroes {
             [] => None,
             [only] => Some(only.0.clone()),
-            [firsts @ .., last] => Some(
+            [firsts @ .., last] => Some({
-                firsts
+                let firsts = firsts
                     .iter()
                     .map(|h| h.0.clone())
                     .collect::<Vec<_>>()
-                    .join(", ")
+                    .join(", ");
-                    + " and "
+
-                    + &last.0,
+                format!("{firsts} and {}", last.0)
-            ),
+            }),
         };
 
         let avatar = if let [only] = &*heroes {

src/service/admin.rs

@@ -385,17 +385,17 @@ impl Service {
                 let output = format!(
                     "Rooms:\n{}",
                     room_ids
-                        .filter_map(|r| r.ok())
+                        .filter_map(std::result::Result::ok)
-                        .map(|id| id.to_string()
+                        .map(|id| format!(
-                            + "\tMembers: "
+                            "{id}\tMembers: {}",
-                            + &services()
+                            &services()
                                 .rooms
                                 .state_cache
                                 .room_joined_count(&id)
                                 .ok()
                                 .flatten()
                                 .unwrap_or(0)
-                                .to_string())
+                        ))
                         .collect::<Vec<_>>()
                         .join("\n")
                 );