backups/grapevine
1
0
Fork 0
mirror of https://gitlab.computer.surgery/matrix/grapevine.git synced 2025-12-16 23:31:24 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

use admin_bot_user_id more

Browse source 
Also change some terminology to be less weird.
This commit is contained in:
Charles Hall 2024-06-12 20:38:29 -07:00
parent d4b5f62bfe
commit b0d85bb575
No known key found for this signature in database
GPG key ID: 7B8E0645816E07CF
2 changed files with 21 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

31
src/database.rs
View file

@ -529,21 +529,12 @@ impl KeyValueDatabase {
// Matrix resource ownership is based on the server name; changing it
// requires recreating the database from scratch.
if services().users.count()? > 0 {
let grapevine_user = UserId::parse_with_server_name(
if services().globals.config.conduit_compat {
"conduit"
} else {
"grapevine"
},
services().globals.server_name(),
)
.expect("admin bot username should be valid");
if !services().users.exists(&grapevine_user)? {
let admin_bot = services().globals.admin_bot_user_id.as_ref();
if !services().users.exists(admin_bot)? {
error!(
"The {} server user does not exist, and the database is \
not new.",
grapevine_user
"The {} admin bot does not exist, and the database is not \
new.",
admin_bot
);
return Err(Error::bad_database(
"Cannot reuse an existing database after changing the \
@ -1221,25 +1212,21 @@ impl KeyValueDatabase {
/// Sets the emergency password and push rules for the @grapevine account in
/// case emergency password is set
fn set_emergency_access() -> Result<bool> {
let grapevine_user = UserId::parse_with_server_name(
"grapevine",
services().globals.server_name(),
)
.expect("@grapevine:server_name is a valid UserId");
let admin_bot = services().globals.admin_bot_user_id.as_ref();
services().users.set_password(
&grapevine_user,
admin_bot,
services().globals.emergency_password().as_deref(),
)?;
let (ruleset, res) = match services().globals.emergency_password() {
Some(_) => (Ruleset::server_default(&grapevine_user), Ok(true)),
Some(_) => (Ruleset::server_default(admin_bot), Ok(true)),
None => (Ruleset::new(), Ok(false)),
};
services().account_data.update(
None,
&grapevine_user,
admin_bot,
GlobalAccountDataEventType::PushRules.to_string().into(),
&serde_json::to_value(&GlobalAccountDataEvent {
content: PushRulesEventContent {

32
src/service/rooms/timeline.rs
View file

@ -516,33 +516,25 @@ impl Service {
&body,
)?;
let server_user = format!(
"@{}:{}",
if services().globals.config.conduit_compat {
"conduit"
} else {
"grapevine"
},
services().globals.server_name()
);
let admin_bot = &services().globals.admin_bot_user_id;
let to_grapevine = body
.starts_with(&format!("{server_user}: "))
|| body.starts_with(&format!("{server_user} "))
|| body == format!("{server_user}:")
|| body == server_user;
let to_admin_bot = body
.starts_with(&format!("{admin_bot}: "))
|| body.starts_with(&format!("{admin_bot} "))
|| body == format!("{admin_bot}:")
|| body == admin_bot.as_str();
// This will evaluate to false if the emergency password is
// set up so that the administrator can
// execute commands as grapevine
let from_grapevine = pdu.sender == server_user
// This will evaluate to false if the emergency password
// is set up so that the administrator can execute commands
// as the admin bot
let from_admin_bot = &pdu.sender == admin_bot
&& services().globals.emergency_password().is_none();
if let Some(admin_room) =
services().admin.get_admin_room()?
{
if to_grapevine
&& !from_grapevine
if to_admin_bot
&& !from_admin_bot
&& admin_room == pdu.room_id
{
services().admin.process_message(body);