backups/grapevine
1
0
Fork 0
mirror of https://gitlab.computer.surgery/matrix/grapevine.git synced 2025-12-17 07:41:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

clarify comments about lazy loading

Browse source
This commit is contained in:
Charles Hall 2024-05-15 23:59:43 -07:00
parent 3efe3fb337
commit bac8b34faf
No known key found for this signature in database
GPG key ID: 7B8E0645816E07CF
1 changed files with 16 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/api/client_server/message.rs
View file

@ -169,9 +169,11 @@ pub(crate) async fn get_message_events_route(
.collect(); .collect();
for (_, event) in &events_after { for (_, event) in &events_after {
/* TODO: Remove this when these are resolved: // * https://github.com/vector-im/element-android/issues/3417
* https://github.com/vector-im/element-android/issues/3417 // * https://github.com/vector-im/element-web/issues/21034
* https://github.com/vector-im/element-web/issues/21034 //
// TODO: When the above issues are resolved, uncomment this:
/*
if !services().rooms.lazy_loading.lazy_load_was_sent_before( if !services().rooms.lazy_loading.lazy_load_was_sent_before(
sender_user, sender_user,
sender_device, sender_device,
@ -181,6 +183,7 @@ pub(crate) async fn get_message_events_route(
lazy_loaded.insert(event.sender.clone()); lazy_loaded.insert(event.sender.clone());
} }
*/ */
// And delete this line:
lazy_loaded.insert(event.sender.clone()); lazy_loaded.insert(event.sender.clone());
} }
@ -218,9 +221,11 @@ pub(crate) async fn get_message_events_route(
.collect(); .collect();
for (_, event) in &events_before { for (_, event) in &events_before {
/* TODO: Remove this when these are resolved: // * https://github.com/vector-im/element-android/issues/3417
* https://github.com/vector-im/element-android/issues/3417 // * https://github.com/vector-im/element-web/issues/21034
* https://github.com/vector-im/element-web/issues/21034 //
// TODO: When the above issues are resolved, uncomment this:
/*
if !services().rooms.lazy_loading.lazy_load_was_sent_before( if !services().rooms.lazy_loading.lazy_load_was_sent_before(
sender_user, sender_user,
sender_device, sender_device,
@ -230,6 +235,7 @@ pub(crate) async fn get_message_events_route(
lazy_loaded.insert(event.sender.clone()); lazy_loaded.insert(event.sender.clone());
} }
*/ */
// And delete this line:
lazy_loaded.insert(event.sender.clone()); lazy_loaded.insert(event.sender.clone());
} }
@ -257,7 +263,10 @@ pub(crate) async fn get_message_events_route(
} }
} }
// TODO: enable again when we are sure clients can handle it // * https://github.com/vector-im/element-android/issues/3417
// * https://github.com/vector-im/element-web/issues/21034
//
// TODO: When the above issues are resolved, uncomment this:
/* /*
if let Some(next_token) = next_token { if let Some(next_token) = next_token {
services().rooms.lazy_loading.lazy_load_mark_sent( services().rooms.lazy_loading.lazy_load_mark_sent(