reduce duplicate events

I hate `log_error`. A better way to do this would be to not reuse the
same error type literally everywhere, so you could distinguish, in
`crate::service::sending::Service::handle_response`, whether to emit an
event based on which function created the error. Fixing that is a lot
more work, though.
This commit is contained in:
Charles Hall 2024-06-23 17:41:53 -07:00
parent 82cc605b5f
commit e83a30af4b
No known key found for this signature in database
GPG key ID: 7B8E0645816E07CF
2 changed files with 12 additions and 8 deletions

View file

@ -130,10 +130,11 @@ impl FedDest {
}
}
#[tracing::instrument(skip(request), fields(url))]
#[tracing::instrument(skip(request, log_error), fields(url))]
pub(crate) async fn send_request<T>(
destination: &ServerName,
request: T,
log_error: bool,
) -> Result<T::IncomingResponse>
where
T: OutgoingRequest + Debug,
@ -330,10 +331,12 @@ where
}
}
Err(e) => {
warn!(
error = %e,
"Could not send request",
);
if log_error {
warn!(
error = %e,
"Could not send request",
);
}
Err(e.into())
}
}