add constructor for spaces service

Also adds a public function to invalidate the cache rather than exposing
the entire cache publicly.

src/service.rs

@@ -3,9 +3,6 @@ use std::{
     sync::{Arc, Mutex as StdMutex, OnceLock},
 };
 
-use lru_cache::LruCache;
-use tokio::sync::Mutex;
-
 use crate::{observability::FilterReloadHandles, Config, Result};
 
 pub(crate) mod account_data;
@@ -171,9 +168,7 @@ impl Services {
                 threads: rooms::threads::Service {
                     db,
                 },
-                spaces: rooms::spaces::Service {
+                spaces: rooms::spaces::Service::new(200),
-                    roomid_spacechunk_cache: Mutex::new(LruCache::new(200)),
-                },
                 user: db,
             },
             transaction_ids: db,

src/service/rooms/spaces.rs

@@ -45,11 +45,19 @@ pub(crate) struct CachedSpaceChunk {
 }
 
 pub(crate) struct Service {
-    pub(crate) roomid_spacechunk_cache:
+    roomid_spacechunk_cache:
         Mutex<LruCache<OwnedRoomId, Option<CachedSpaceChunk>>>,
 }
 
 impl Service {
+    pub(crate) fn new(roomid_spacechunk_cache_size: usize) -> Self {
+        Self {
+            roomid_spacechunk_cache: Mutex::new(LruCache::new(
+                roomid_spacechunk_cache_size,
+            )),
+        }
+    }
+
     #[allow(clippy::too_many_lines)]
     #[tracing::instrument(skip(self))]
     pub(crate) async fn get_hierarchy(
@@ -518,6 +526,10 @@ impl Service {
         })
     }
 
+    pub(crate) async fn invalidate_cache(&self, room_id: &RoomId) {
+        self.roomid_spacechunk_cache.lock().await.remove(room_id);
+    }
+
     fn translate_joinrule(join_rule: &JoinRule) -> Result<SpaceRoomJoinRule> {
         match join_rule {
             JoinRule::Invite => Ok(SpaceRoomJoinRule::Invite),

src/service/rooms/state.rs

@@ -103,10 +103,8 @@ impl Service {
                     services()
                         .rooms
                         .spaces
-                        .roomid_spacechunk_cache
+                        .invalidate_cache(&pdu.room_id)
-                        .lock()
+                        .await;
-                        .await
-                        .remove(&pdu.room_id);
                 }
                 _ => continue,
             }

src/service/rooms/timeline.rs

@@ -508,14 +508,12 @@ impl Service {
                 };
             }
             TimelineEventType::SpaceChild => {
-                if let Some(_state_key) = &pdu.state_key {
+                if pdu.state_key.is_some() {
                     services()
                         .rooms
                         .spaces
-                        .roomid_spacechunk_cache
+                        .invalidate_cache(&pdu.room_id)
-                        .lock()
+                        .await;
-                        .await
-                        .remove(&pdu.room_id);
                 }
             }
             TimelineEventType::RoomMember => {