2672 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Charles Hall	44b15dcb08	enable wildcard_imports lint	2024-05-14 20:01:25 -07:00
Charles Hall	3978b9c580	enable used_underscore_binding lint	2024-05-14 20:01:25 -07:00
Charles Hall	e3672eb4e0	enable unused_self lint ... Functions using `services()` are allowed to pointlessly take `self` because the existence of `services()` is a crime and the solution is making the types store references to their dependencies and then going through `self`, so just allowing the lint saves us from modifying some code only to switch it back later. Much later. Getting rid of `services()` will probably be an ordeal.	2024-05-14 20:01:25 -07:00
Charles Hall	f855bd09d1	enable unused_async lint ... This also caused a "new" `unnecessary_wraps` lint to fire too, so that got fixed too.	2024-05-14 20:01:25 -07:00
Charles Hall	4419e855ae	enable unreadable_literal lint	2024-05-14 20:01:25 -07:00
Charles Hall	a4ff32667e	enable unnested_or_patterns lint	2024-05-14 20:01:25 -07:00
Charles Hall	4e80dc028e	enable unnecessary_wraps lint	2024-05-14 20:01:25 -07:00
Charles Hall	86218f4771	enable uninlined_format_args lint	2024-05-14 20:01:24 -07:00
Charles Hall	baab928281	enable too_many_lines lint ... And just disable it everywhere it fires, I know.	2024-05-14 20:01:24 -07:00
Charles Hall	8ef278d358	enable struct_excessive_bools lint ... And ignore it in the one place it fires, I know.	2024-05-14 20:01:24 -07:00
Charles Hall	75358340bb	enable single_match_else lint ... Also collapses some if statements in the federation name resolution code	2024-05-14 20:01:24 -07:00
Charles Hall	a62fa7b6ee	enable similar_names lint	2024-05-14 20:01:24 -07:00
Charles Hall	db4951c5fd	enable semicolon_if_nothing_returned lint	2024-05-14 20:01:24 -07:00
Charles Hall	96e1877639	enable redundant_closure_for_method_calls lint	2024-05-14 20:01:24 -07:00
Charles Hall	a636405bed	enable needless_pass_by_value lint	2024-05-14 20:01:24 -07:00
Charles Hall	c4a9bca16f	enable match_wildcard_for_single_variants lint	2024-05-14 20:01:24 -07:00
Charles Hall	2b8b5ccb1a	enable match_same_arms lint	2024-05-14 20:01:24 -07:00
Charles Hall	4e6c8451ca	enable match_bool lint	2024-05-14 20:01:24 -07:00
Charles Hall	224ba65d06	enable map_unwrap_or lint	2024-05-14 20:01:24 -07:00
Charles Hall	645d88177a	enable manual_string_new lint	2024-05-14 20:01:24 -07:00
Charles Hall	9606f59141	enable manual_let_else lint	2024-05-14 20:01:23 -07:00
Charles Hall	c51e87ec9a	enable items_after_statements lint	2024-05-14 19:59:43 -07:00
Charles Hall	5c9967f89c	enable inconsistent_struct_constructor lint	2024-05-14 19:59:43 -07:00
Charles Hall	ebae8ceeb0	enable implicit_clone lint	2024-05-14 19:59:43 -07:00
Charles Hall	b0f65913f3	enable ignored_unit_patterns lint	2024-05-14 19:59:43 -07:00
Charles Hall	623824dc0c	enable if_not_else lint	2024-05-14 19:59:40 -07:00
Charles Hall	a32b7c1ac1	enable flat_map_option lint	2024-05-14 16:41:04 -07:00
Charles Hall	703e08947f	enable explicit_into_iter_loop lint	2024-05-14 16:38:21 -07:00
Charles Hall	cb2cd6e253	enable enum_glob_use lint	2024-05-14 16:36:45 -07:00
Charles Hall	da440934bd	enable doc_markdown lint	2024-05-14 16:34:10 -07:00
Charles Hall	0f2cf26a36	enable default_trait_access lint	2024-05-14 16:08:26 -07:00
Charles Hall	da842c6499	enable unneeded_field_pattern lint	2024-05-12 19:14:59 -07:00
Charles Hall	2b6a933538	enable undocumented_unsafe_blocks lint ... There was only one unsafe block (thankfully) but it also had no docs. I did some reading and found out this in fact safe, but only for cursed reasons, and documented them. Also, the name of the type was misleading, as the entire point is the aliasing, and `Box` is already non-aliasing.	2024-05-12 19:10:31 -07:00
Charles Hall	844b32f097	enable string_slice lint ... Also swaps out vendored HTML-escaping code for a dependency that I imagine has decent testing considering all of its reverse depedencies.	2024-05-12 19:08:12 -07:00
Charles Hall	9abe4799db	enable string_add lint	2024-05-12 19:01:29 -07:00
Charles Hall	cc5977b4e4	enable same_name_method lint	2024-05-12 18:51:48 -07:00
Charles Hall	d144db8688	enable ref_patterns lint	2024-05-12 18:51:27 -07:00
Charles Hall	6bdaeab1af	enable multiple_inherent_impl lint	2024-05-12 18:51:27 -07:00
Charles Hall	4a7b9c16cc	enable missing_assert_message lint	2024-05-12 18:51:27 -07:00
Charles Hall	052f3088e9	enable let_underscore_must_use lint	2024-05-12 18:51:26 -07:00
Charles Hall	2ded335adb	enable impl_trait_in_params lint ... See also <https://github.com/rust-lang/rust-clippy/issues/12792>.	2024-05-12 18:51:26 -07:00
Charles Hall	52c2893073	enable if_then_some_else_none lint	2024-05-12 18:51:26 -07:00
Charles Hall	bd6ea4e358	enable format_push_string lint	2024-05-12 18:51:26 -07:00
Charles Hall	5fd156a6bb	enable error_impl_error lint ... Except the 1 violation would have to be renamed in, like, every single file in this project. So we're just enabling it so that we don't make the same mistake in the future.	2024-05-12 18:51:26 -07:00
Charles Hall	a127253daa	enable empty_struct_with_brackets lint	2024-05-12 18:51:26 -07:00
Charles Hall	885fc8428c	enable deref_by_slicing lint	2024-05-12 18:51:26 -07:00
Charles Hall	71c48f66c4	enable as_conversions lint ... There were some very, uh, creative (and inconsistent) ways to convert between numeric types in here...	2024-05-12 18:51:26 -07:00
Charles Hall	a78bf8f50b	enable unused_lifetimes lint	2024-05-12 18:51:26 -07:00
Charles Hall	5d5e28770b	enable single_use_lifetimes lint	2024-05-12 18:51:26 -07:00
Charles Hall	bc2f7c6826	enable enum_variant_names lint	2024-05-12 18:51:26 -07:00